Skip to content

update project templates use primary constructors #55006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

update project templates use primary constructors #55006

wants to merge 2 commits into from

Conversation

Varorbc
Copy link
Contributor

@Varorbc Varorbc commented Apr 8, 2024 •
edited
Loading

update project templates use primary constructors

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

Fixes #52893

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 8, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 8, 2024
davidfowl
davidfowl reviewed Apr 8, 2024
View reviewed changes
@davidfowl
Copy link
Member

@Varorbc can you undo all of the non code changes that aren't required as part of this PR?

@Varorbc Varorbc requested a review from davidfowl April 8, 2024 06:28
@mkArtakMSFT mkArtakMSFT added area-ui-rendering Includes: MVC Views/Pages, Razor Views/Pages and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Apr 8, 2024
FarazJahanmanesh
FarazJahanmanesh reviewed Apr 9, 2024
View reviewed changes
Copy link

@FarazJahanmanesh FarazJahanmanesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done thanks to use Private constructors

@Varorbc
Copy link
Contributor Author

Varorbc commented Apr 11, 2024

@javiercn Can you review and give me some suggestions?

javiercn
javiercn approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@danroth27 are you happy with the change to the templates?

@javiercn
Copy link
Member

/AzurePipelines run AspNetCore-ci

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@javiercn
Copy link
Member

/AzurePipelines run aspnetcore-components-e2e

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

danroth27
danroth27 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Apr 23, 2024
@halter73 halter73 enabled auto-merge (squash) December 13, 2024 23:36
@mkArtakMSFT
Copy link
Contributor

Looks like there are some test failures here. @Varorbc could you please address the issues so that we can get this merged.

@mkArtakMSFT mkArtakMSFT added the pr: pending author input For automation. Specifically separate from Needs: Author Feedback label Dec 15, 2024
@Varorbc
Copy link
Contributor Author

Varorbc commented Dec 16, 2024

@mkArtakMSFT Alright, I'll take care of the failed tests. But here's what happened: I pulled the latest code today and tried running command src\ProjectTemplates\build.cmd -pack -configuration Release to compile it on my local machine, and I got error microsoft.dotnet.build.tasks.installers\10.0.0-beta.24612.1\build\wix\wix.targets(365,5): error : Exec FAILED: exit code 217 (attempt 5/5). Can you help me figure out what's going on and how to fix it?

auto-merge was automatically disabled December 20, 2024 07:54

Head branch was pushed to by a user without write access

@Varorbc
Copy link
Contributor Author

Varorbc commented Dec 21, 2024

@mkArtakMSFT @halter73 All the tests are green

@dotnet-policy-service dotnet-policy-service bot added the stale Indicates a stale issue. These issues will be closed automatically soon. label Dec 31, 2024
@Varorbc Varorbc requested a review from danroth27 December 31, 2024 05:04
@danroth27
Copy link
Member

@mkArtakMSFT Looks like this got closed by the policy bot over the holidays. New PR opened by the contributor here: #59712.

@Varorbc Sorry about the run around on this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidfowl davidfowl Awaiting requested review from davidfowl

@FarazJahanmanesh FarazJahanmanesh Awaiting requested review from FarazJahanmanesh

@javiercn javiercn Awaiting requested review from javiercn

@halter73 halter73 Awaiting requested review from halter73

@danroth27 danroth27 Awaiting requested review from danroth27

Assignees

@javiercn javiercn

Labels

area-ui-rendering Includes: MVC Views/Pages, Razor Views/Pages community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun pr: pending author input For automation. Specifically separate from Needs: Author Feedback stale Indicates a stale issue. These issues will be closed automatically soon.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

update project templates use primary constructors

7 participants

@Varorbc @davidfowl @javiercn @mkArtakMSFT @danroth27 @halter73 @FarazJahanmanesh